Gentoo Forums
Gentoo Forums
Gentoo Forums
Quick Search: in
Samsung SSD 850 Pro dive blacklisted in kernel for Trim?
View unanswered posts
View posts from last 24 hours

 
Reply to topic    Gentoo Forums Forum Index Kernel & Hardware
View previous topic :: View next topic  
Author Message
dman777
l33t
l33t


Joined: 10 Jan 2007
Posts: 982

PostPosted: Tue Jun 28, 2016 6:11 am    Post subject: Samsung SSD 850 Pro dive blacklisted in kernel for Trim? Reply with quote

I was thinking about buying a Samsung SSD 850 Pro dive. But after doing some research, it uses `que` trim which has issues in Linux...where Linux supports regular trim, not the que trim.

Am I looking at this right? Is the trim still blacklisted for Samsung SSD 850 Pro dive? Or is this only for Raids?

https://github.com/torvalds/linux/blob/e64f638483a21105c7ce330d543fa1f1c35b5bc7/drivers/ata/libata-core.c#L4238

Code:
static const struct ata_blacklist_entry ata_device_blacklist [] = {
   { "Samsung SSD 8*",      NULL,   ATA_HORKAGE_NO_NCQ_TRIM | ATA_HORKAGE_ZERO_AFTER_TRIM, },

_________________
<h5>Checkout <em>#grandmasboy</em> on <em>freenode</em>...chat with jayP bot from the movie!</h5>
Back to top
View user's profile Send private message
snkmoorthy
Guru
Guru


Joined: 19 Nov 2002
Posts: 376

PostPosted: Tue Jun 28, 2016 6:50 am    Post subject: Reply with quote

I use this drive, without 'discard' mount option, without any issues for about a year now, if discard is enabled, system becomes laggy when doing IO.
Back to top
View user's profile Send private message
frostschutz
Advocate
Advocate


Joined: 22 Feb 2005
Posts: 2971
Location: Germany

PostPosted: Tue Jun 28, 2016 7:31 am    Post subject: Reply with quote

Trim works fine unqueued. There have been so many NCQ related bugs that I disable it altogether (libata.force=noncq) and no performance issues because of it.

I don't use discard option, fstrim on a weekly/monthly basis is fine. Doesn't affect I/O this way either.
Back to top
View user's profile Send private message
dman777
l33t
l33t


Joined: 10 Jan 2007
Posts: 982

PostPosted: Tue Jun 28, 2016 7:57 am    Post subject: Reply with quote

snkmoorthy wrote:
I use this drive, without 'discard' mount option, without any issues for about a year now, if discard is enabled, system becomes laggy when doing IO.


Strange, how would discard have a effect if it is blacklisted in the kernel?
_________________
<h5>Checkout <em>#grandmasboy</em> on <em>freenode</em>...chat with jayP bot from the movie!</h5>
Back to top
View user's profile Send private message
dman777
l33t
l33t


Joined: 10 Jan 2007
Posts: 982

PostPosted: Tue Jun 28, 2016 8:01 am    Post subject: Reply with quote

frostschutz wrote:
Trim works fine unqueued. There have been so many NCQ related bugs that I disable it altogether (libata.force=noncq) and no performance issues because of it.

I don't use discard option, fstrim on a weekly/monthly basis is fine. Doesn't affect I/O this way either.


Is it possible to enable trim with discard and have it non queued?

Also, currently I use deadline for /sys/block/sda/queue/scheduler....is trim being queued(for SSDs in general....not any specific model)?
_________________
<h5>Checkout <em>#grandmasboy</em> on <em>freenode</em>...chat with jayP bot from the movie!</h5>
Back to top
View user's profile Send private message
comio
Advocate
Advocate


Joined: 03 Jul 2003
Posts: 2191
Location: Taranto

PostPosted: Tue Jun 28, 2016 8:45 am    Post subject: Re: Samsung SSD 850 Pro dive blacklisted in kernel for Trim? Reply with quote

dman777 wrote:
I was thinking about buying a Samsung SSD 850 Pro dive. But after doing some research, it uses `que` trim which has issues in Linux...where Linux supports regular trim, not the que trim.

Am I looking at this right? Is the trim still blacklisted for Samsung SSD 850 Pro dive? Or is this only for Raids?

https://github.com/torvalds/linux/blob/e64f638483a21105c7ce330d543fa1f1c35b5bc7/drivers/ata/libata-core.c#L4238

Code:
static const struct ata_blacklist_entry ata_device_blacklist [] = {
   { "Samsung SSD 8*",      NULL,   ATA_HORKAGE_NO_NCQ_TRIM | ATA_HORKAGE_ZERO_AFTER_TRIM, },


Read this:

https://en.wikipedia.org/wiki/Trim_(computing)#Shortcomings

ciao

luigi

[Moderator edit: fixed link. Automatic linking does not consider parentheses as part of the URL.]
_________________
RTFM!!!!

e

http://www.comio.it
:)
Back to top
View user's profile Send private message
dman777
l33t
l33t


Joined: 10 Jan 2007
Posts: 982

PostPosted: Tue Jun 28, 2016 6:54 pm    Post subject: Reply with quote

Good read, thanks!

Question.... with the discard option, does non queue trim run on the Samsung 850? Or is all trim blacklisted with
Code:

static const struct ata_blacklist_entry ata_device_blacklist [] = {
   { "Samsung SSD 8*",      NULL,   ATA_HORKAGE_NO_NCQ_TRIM | ATA_HORKAGE_ZERO_AFTER_TRIM, },

_________________
<h5>Checkout <em>#grandmasboy</em> on <em>freenode</em>...chat with jayP bot from the movie!</h5>
Back to top
View user's profile Send private message
Display posts from previous:   
Reply to topic    Gentoo Forums Forum Index Kernel & Hardware All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum